Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields editing: modal #644

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Fields editing: modal #644

merged 4 commits into from
Sep 18, 2023

Conversation

valery-tm
Copy link
Contributor

@valery-tm valery-tm commented Sep 18, 2023 •
edited
Loading

Editing of the fields should happen in a modal instead of in-document.

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 6ffa86a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystatic/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keystar-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 4:07am
keystatic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 4:07am
keystatic-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 4:07am

@valery-tm valery-tm changed the title Editing in modal instead of inline Fields editing: modal Sep 18, 2023
@valery-tm valery-tm marked this pull request as ready for review September 18, 2023 02:15
@valery-tm valery-tm requested a review from emmatown as a code owner September 18, 2023 02:15
emmatown
emmatown reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

packages/keystatic/src/form/api.tsx Outdated Show resolved Hide resolved
...ges/keystatic/src/form/fields/document/DocumentEditor/component-blocks/chromeful-element.tsx Outdated Show resolved Hide resolved
...ges/keystatic/src/form/fields/document/DocumentEditor/component-blocks/chromeful-element.tsx Outdated Show resolved Hide resolved
@valery-tm valery-tm requested a review from emmatown September 18, 2023 03:51
emmatown
emmatown approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@valery-tm valery-tm merged commit df4f06a into main Sep 18, 2023
6 checks passed
@valery-tm valery-tm deleted the editor/edit-in-modal branch September 18, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valery-tm @emmatown